-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Library: Social Link: Fix label attribute type as string #20468
Conversation
Size Change: -1 B Total Size: 866 kB
ℹ️ View Unchanged
|
Quickly tested and works from an a11y perspective. @aduth can you confirm any previously entered value for the aria-label needs to be re-saved for this change to have effect? Can this be cherry-picked and included in WordPress 5.4? |
@afercia Existing content should automatically be fixed with these changes, since the rendered content is dynamically generated server-side. I've marked it as "WordPress 5.4 Must Have", such that it should be cherry-picked in time for 5.4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, how did this happen? :/ Thanks for catching it!
Reported by @afercia at #18651 (comment)
Regression of #19887
This pull request seeks to resolve an issue where custom
aria-label
assigned to a Social Link block will otherwise not be represented on the front of a site.Testing Instructions:
aria-label
is correctly assigned to the rendered link element