-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FSE: Get current template part correctly for auto drafts #20438
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epiqueras
added
[Type] Bug
An existing feature does not function as intended
[Feature] Full Site Editing
labels
Feb 25, 2020
Size Change: 0 B Total Size: 857 kB ℹ️ View Unchanged
|
…plate parts in the editor.
noahtallen
force-pushed
the
fix/edit-site-error
branch
from
March 16, 2020 22:27
66c3d88
to
c80e8bb
Compare
noahtallen
approved these changes
Mar 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that this fixes the PHP notice that was displayed locally
noahtallen
changed the title
Template Loader: Get current template correctly for auto drafting template parts in the editor.
FSE: Get current template part correctly for auto drafts
Mar 16, 2020
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the PHP notice that was being shown when the site editor loads by correctly getting the current post for auto-drafting template parts depending on whether a template or post is currently being edited.
How to test this?
Verify there are no regressions or PHP notices in the site editor.
Checklist: