Env: Add support for ZIP URL sources. #20426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 865 kB ℹ️ View Unchanged
|
|
Why do we extract the zip to a temporary directory before copying the files to the final destination? Does extracting the zip straight to the final destination not work? |
|
No, because you get a nested folder. |
noisysocks
reviewed
Feb 26, 2020
noisysocks
reviewed
Feb 26, 2020
noisysocks
reviewed
Feb 26, 2020
noisysocks
approved these changes
Feb 26, 2020
|
All addressed, thanks for the review! |
|
Hi @epiqueras should this PR be backported into WordPress 5.4? If yes, feel free to add the label backport to wp core. |
|
Yes |
6 tasks
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 2, 2020
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 2, 2020
aduth
reviewed
Apr 1, 2020
| "inquirer": "^7.0.4", | ||
| "js-yaml": "^3.13.1", | ||
| "nodegit": "^0.26.2", | ||
| "ora": "^4.0.2", | ||
| "request": "^2.88.2", |
There was a problem hiding this comment.
Noting that request is deprecated, even at the time it was introduced here:
https://www.npmjs.com/package/request
request/request#3142
Which isn't necessarily to say that a deprecation is bad, but we can't expect any future maintenance (which could become problematic for security issues and the like). Another option like got, bent (from the author of request), or just straight https may be a more reliable long-term dependency. For the specific needs of progress events, the first of these alternatives does have the most compatible API for how we're using it here, though a combination of an https response Content-Length header plus an incrementing value in a stream iteration may suffice as well.
There was a problem hiding this comment.
Thanks for the heads up. Created an issue here: #21336
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advances #20325
Description
This PR adds support for ZIP URL sources to
wp-env.How has this been tested?
It was verified that using ZIP URL sources like "https://wordpress.org/wordpress-5.4-beta2.zip" for core, works as expected.
Types of Changes
New Feature: URLs for ZIP files are now supported as core, plugin, and theme sources in
wp-env.Checklist: