-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify cover image markup structure #2038
Conversation
@jasmussen can you give this a look, please? |
I'm having some trouble with a react dom JS error with the demo content, so I can't check right now sadly. It seems unrelated to this PR, though, as it's happening on all demo content for me. |
@youknowriad I'm not able to reproduce the issue you're seeing. I did find that I neglected to deduplicate styles between |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why but it seems fixed now. Thanks
6a960cb
to
40db4e8
Compare
Codecov Report
@@ Coverage Diff @@
## master #2038 +/- ##
=======================================
Coverage 20.24% 20.24%
=======================================
Files 130 130
Lines 4184 4184
Branches 712 711 -1
=======================================
Hits 847 847
- Misses 2811 2812 +1
+ Partials 526 525 -1
Continue to review full report at Codecov.
|
This pull request seeks to simplify the markup structure of the cover image block, from a set of two nested
section
elements to a singlesection
element, flattening classes, and applying thehasBackgroundDim
default attribute consistently.These changes should also resolve the "corrupt" warning shown for the first block in the Demo content screen.
Testing instructions:
Verify that Cover Image block behavior continues to work as expected, particularly dimming and fixed background, and that no warning is shown in the Demo content screen.