Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ubuntu setup documentation #20261

Closed

Conversation

sainthkh
Copy link
Contributor

Closes #20260

Description

Added specific steps after installing and setting up docker to finish the WordPress installation.

How has this been tested?

N/A

Screenshots

N/A

Types of changes

Bug fix (document fix)

Checklist:

  • [N/A] My code is tested.
  • [N/A] My code follows the WordPress code style.
  • [N/A] My code follows the accessibility standards.
  • [N/A] My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • [N/A] I've updated all React Native files affected by any refactorings/renamings in this PR.

Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I'm also on Ubuntu. I wasn't aware of the env-ubuntu doc, but recently ran into the same issue when following the "Getting Started" doc. People pointed me to the new wp-env based setup, and I updated that doc accordingly (#20044).

(The gist is that instead of using npm run env start, you now run npx wp-env start.)

I think that the env-ubuntu doc should be aligned with the Getting Started doc -- both should suggest either npm run env start, or npx wp-env start -- and from what people have told me, it's the latter that we're going to commit to.

@sainthkh
Copy link
Contributor Author

@ockham I'll follow the new doc and check if it works.

@sainthkh
Copy link
Contributor Author

sainthkh commented Feb 17, 2020

As you raised this issue in #20180, it seems that npx wp-env start doesn't work for now in Ubuntu.

It seems that the problem wasn't that easy as fixing this document.

EDIT: was -> wasn't.

@talldan
Copy link
Contributor

talldan commented Feb 17, 2020

it seems that npx wp-env start doesn't work for now in Ubuntu.

Hey @sainthkh, in what way doesn't it work?

edit: Oh, sorry, I see you linked to #20180 which has more details.

@talldan talldan added [Tool] Env /packages/env [Type] Developer Documentation Documentation for developers labels Feb 18, 2020
@mkaz
Copy link
Member

mkaz commented Sep 10, 2020

I updated the docs in PR #25060 based on the latest Ubuntu version 20.04.1

Can you confirm the updated documentation works as expected, you can view directly here:
https://developer.wordpress.org/block-editor/tutorials/devenv/docker-ubuntu/

If so, I think we can close this PR.

@sainthkh
Copy link
Contributor Author

@mkaz It works. Close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Tool] Env /packages/env [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in Ubuntu local development troubleshooting doc.
4 participants