EditorSkeleton: Add Changelog entries, drop backwards-compat class names #20132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
reviewed
Feb 10, 2020
| @@ -1,3 +1,7 @@ | |||
| ## Master | |||
|
|
|||
| - Add new `__experimentalEditorSkeleton` component. This has been moved over from the `@wordpress/edit-post` package, where it was an internal component called `EditorRegions`. Its class names have thus been renamed from `edit-post-editor-regions` to `block-editor-editor-skeleton`. | |||
There was a problem hiding this comment.
In general we add "sections" to changelog entries. I believe this one could be "### New Features" and the other one could be ### Internal
There was a problem hiding this comment.
Ah right, thanks. Done in 67061c6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #20050, where the component was moved and renamed.
Dropping backwards-compat classnames as discussed here.
How has this been tested?
Rebuild Gutenberg (
npm run build), and start it (npx wp-env start). Verify that the editor styling isn't broken (specifically regions like header or sidebar).Types of changes
Add Changelog entries, drop backwards-compat class names.
Checklist: