Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide gallery display settings in the media modal #1978

Merged
merged 1 commit into from
Jul 23, 2017
Merged

Hide gallery display settings in the media modal #1978

merged 1 commit into from
Jul 23, 2017

Conversation

joemcgill
Copy link
Member

Following #1820, this hides the display settings in the media modal when the frame is in the gallery-edit state, since the settings aren't being used by Gutenberg anyway.

Before:
screen shot 2017-07-22 at 11 59 55 am

After:
screen shot 2017-07-22 at 11 58 58 am

@joemcgill
Copy link
Member Author

cc: @westonruter, @mkaz.

@westonruter westonruter merged commit 1d66b18 into WordPress:master Jul 23, 2017
@mtias
Copy link
Member

mtias commented Jul 24, 2017

Thanks!

@mtias mtias added [Feature] Media Anything that impacts the experience of managing media [Feature] Blocks Overall functionality of blocks General Interface Parts of the UI which don't fall neatly under other labels. and removed [Feature] Blocks Overall functionality of blocks General Interface Parts of the UI which don't fall neatly under other labels. labels Jul 24, 2017
@saulirajala saulirajala mentioned this pull request Sep 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

Assignees
No one assigned
Labels
[Feature] Media Anything that impacts the experience of managing media General Interface Parts of the UI which don't fall neatly under other labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joemcgill @mtias @westonruter