-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook: Update to latest 5.3 #19599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need to deal with:
- We've deprecated the ability to specify the hierarchy separators (how you control the grouping of story kinds in the sidebar). From Storybook 6.0 we will have a single separator /, which cannot be configured.
- In 5.3, the CSF loader decouples the story's name/id, which means that displayName is no longer necessary. Unfortunately, this is a breaking change for any code that uses the story name field. Storyshots relies on story name, and the appropriate migration is to simply update your snapshots. Apologies for the inconvenience!
@epiqueras I just pushed the updates to the |
Thanks, we still need to update the snapshots. |
@epiqueras Oh! Thanks for the reminder <3 Will keep investigating Update: Fixed. I think it's the |
You need to mock the refs. |
This update bumps Storybook to the latest 5.3.2 release. Some of the core `.js` files have been renamed and refactored according to their 5.2.x -> 5.3 migration guides. This update also start some Storybook theming, adding the WordPress branding logo on the top left.
Rebasing with latest |
0e48d50
to
5752fc8
Compare
https://travis-ci.com/WordPress/gutenberg/jobs/275074009#L398 It looks like types checking errors for some unknown reasons. |
@gziolo Interesting 🤔. I'm not sure what's up with that. I'll poke at it to see if I can debug. Thank you!! |
This update fixes the Jest type checking issue by installing the latest @types/jest definitions as a devDependency.
@gziolo Halloo!! I think I fixed it 🙏 . I installed the latest I based this fix off of this GH issue: |
Thanks for the review @epiqueras !! Will merge 💪 |
This update bumps Storybook to the latest 5.3.2 release. Some of the core
.js
files have been renamed and refactored according to their 5.2.x -> 5.3
migration guides.
This update also start some Storybook theming, adding the WordPress branding
logo on the top left.
#branding
The WP logo is being served from a URL. Originally, I tried to serve the image locally. However, I don't think it's working correctly with Storybook.
storybookjs/storybook#5878
storybookjs/storybook#6521
Maybe able to resolve this with Webpack work-arounds?
How has this been tested?
Run storybook locally via
npm run storybook:dev
. Also did a local build vianpm run storybook:build
. I tested the localdist
build of storybook separately to ensure that it will work when built/deployed.Types of changes
5.2.4
->5.3.2
Checklist: