Block Library: Add a Post Excerpt block. #19579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
reviewed
Jan 13, 2020
|
|
||
| function PostExcerptDisplay() { | ||
| const [ excerpt ] = useEntityProp( 'postType', 'post', 'excerpt' ); | ||
| return <RichText.Content tagName="p" value={ excerpt } />; |
There was a problem hiding this comment.
In the sidebar of the editor, we use a TextareaControl to edit the excerpt, it makes me think we should use PlainText here. any reason for not making this editable?
There was a problem hiding this comment.
I was trying to be minimal with these changes by making the new blocks read-only first so that we can land them faster and then iterate.
I've changed it to use PlainText now since I agree it is more fitting, and the complexity doesn't increase much.
youknowriad
reviewed
Jan 13, 2020
|
|
||
| export default function PostExcerptEdit() { | ||
| if ( ! useEntityId( 'postType', 'post' ) ) { | ||
| return 'Post Excerpt Placeholder'; |
There was a problem hiding this comment.
I don't think we should use it here.
This is a temporary placeholder while #19256 is worked on.
This was referenced Jan 13, 2020
youknowriad
approved these changes
Jan 13, 2020
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new Post Excerpt block akin to the Post Title and Post Content blocks.
How has this been tested?
Types of Changes
New Feature: There is a new Post Excerpt block for template building.
Checklist: