Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes cherry-picked to be included in WordPress 5.3.1 #18932

Merged
merged 3 commits into from
Dec 5, 2019
Merged

Fixes cherry-picked to be included in WordPress 5.3.1 #18932

merged 3 commits into from
Dec 5, 2019

Conversation

youknowriad
Copy link
Contributor

ellatrix and others added 3 commits December 5, 2019 09:45
@ellatrix @youknowriad
Typewriter: use DOMRect.top to fix for Edge (#17707)
488b779
@epiqueras @youknowriad
Core Data: Add checks to actions and selectors to avoid throwing erro…
aef01f8 
…rs when the relevant config is not loaded. (#18559)

* Core Data: Add checks to selectors to avoid throwing errors when the relevant config is not loaded.

* Core Data: Throw when `editEntityRecord` targets an entity without a config.

* Core Data: Fix default value typo in `getEntityRecordNonTransientEdits`.

* Core Data: Test the behavior of `editEntityRecord` and `getEntityRecordNonTransientEdits` on entities without configs.
@audrasjb @youknowriad
Remove CollegeHumor from embed providers (#18591)
97c226f 
* Remove CollegeHumor from embed provider since the service doesn’t exists anymore.

* Update deprecation logic

* Update deprecated pattterns

* Remove unwanted patterns

* lint fixes

* undo unwanted changes in package-lock.json

* remove unwanted changes, second pass

* Remove CollegeHumor from embed provider since the service doesn’t exists anymore.

* Update deprecation logic

* Update deprecated pattterns

* Remove unwanted patterns

* lint fixes

* undo unwanted changes in package-lock.json

* remove unwanted changes, second pass
@youknowriad youknowriad self-assigned this Dec 5, 2019
gziolo
gziolo approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's publish and test with WordPress core 👍

@youknowriad youknowriad merged commit f79aef2 into wp/5.3 Dec 5, 2019
@youknowriad youknowriad deleted the fixes/wp-5.3.1 branch December 5, 2019 10:38
@gziolo gziolo mentioned this pull request Dec 5, 2019
Merged
@ZebulanStanphill
Copy link
Member

ZebulanStanphill commented Dec 5, 2019 •
edited
Loading

Is it too late to get #18842 cherry-picked into WP 5.3.1?

@youknowriad
Copy link
Contributor Author

@ZebulanStanphill It is, unfortunately, I mean it's not strict entirely we can still add things but it's not a simple process so I'm thinking #18842 is not critical enough to perform this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix is a code owner

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta jorgefilipecosta is a code owner

@nerrad nerrad Awaiting requested review from nerrad nerrad is a code owner

@Soean Soean Awaiting requested review from Soean Soean is a code owner

@talldan talldan Awaiting requested review from talldan talldan is a code owner

Assignees

@youknowriad youknowriad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@youknowriad @ZebulanStanphill @gziolo @ellatrix @epiqueras @audrasjb