Add linting task to check IE compatibility #18774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epiqueras
reviewed
Nov 27, 2019
package.json
Outdated
| @@ -178,6 +178,7 @@ | |||
| "fixtures:generate": "npm run fixtures:server-registered && cross-env GENERATE_MISSING_FIXTURES=y npm run test-unit", | |||
| "fixtures:regenerate": "npm run fixtures:clean && npm run fixtures:generate", | |||
| "lint": "concurrently \"npm run lint-js\" \"npm run lint-pkg-json\" \"npm run lint-css\" \"npm run lint-types\"", | |||
| "lint-es5-only": "npx eslint --parser-options=ecmaVersion:5 --no-eslintrc --no-ignore ./build/**/*.js", | |||
There was a problem hiding this comment.
I think we should inline this into the Travis config. It's not really something developers will run locally and npx and eslint are not direct, local dependencies.
There was a problem hiding this comment.
Hmm good point. Although in theory devs could use it locally to check if new dependencies are IE-compatible, it'll probably never happen 😁
There was a problem hiding this comment.
Noting two things:
npxhere would be redundant anyways, since NPM will include./node_modules/.binin thePATHwhen running any script. So the line here would work fine (the same) if runningeslintdirectly.- If ESLint is not a defined dependency, then we shouldn't have confidence that it would be installed in Travis either. I have a feeling this is only incidentally working because it's some transitive dependency of another package (probably one of the ESLint plugins which are defined as dependencies).
There was a problem hiding this comment.
But npx installs it if it's not there.
There was a problem hiding this comment.
But
npxinstalls it if it's not there.
Ah, you're right! I always forget that part of it.
epiqueras
approved these changes
Nov 27, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a script to lint built JS files checking for any ES > 5 that might break on IE11.
Added task to run script in Travis.
How has this been tested?
Tested locally by running
npm run buildfollowed bynpm run lint-es5-only. On latest master, no errors should appear.Checking out
69e7fc7060651c65b394944bda00759e232ade33(or any commit beforehex-rgbwas removed) and re-running the above commands should result in an error traceable to thehex-rgbpackage.Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: