-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the copy of the Experiments page #18233
Conversation
lib/experiments-page.php
Outdated
@@ -80,7 +80,7 @@ function gutenberg_initialize_experiments_settings() { | |||
'gutenberg-experiments', | |||
'gutenberg_experiments_section', | |||
array( | |||
'label' => __( 'Enable Full Site Editing', 'gutenberg' ), | |||
'label' => __( 'Enable Full Site Editing (Warning: this will break the site)', 'gutenberg' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another option would be to mark it as (Unstable)
, and then clarify below what it actually means. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imho "unstable" doesn't sound dangerous enough 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the warning is now hard to miss. Looks like a good change.
and then clarify below what it actually means.
Perhaps it is worth considering clarifying below what "break the site" means, but I think the warning gets the main point across.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il approve for what it's worth. It definitely seems like a good fix to make that warning a bit more apparent while FSE is being developed. It does look like we still have reviews requested from others though.
I see the need for an additional warning, but the current text does seem extreme. I agree that it might be worth elaborating some more on what happens (e.g. 'Warning: this will replace your theme and cause potentially irreversible changes to your site. Please consider using this only in a development environment.')
Maybe WordPress.com needs some more control over whether the experiments are visible or be able to override specific experiments to be disabled using a filter or something similar. |
@talldan Yup, the copy here was intended as a placeholder to get the discussion going.
There are some specific cases in which we might want to leave the experiments available to users. |
31edab4
to
ccb3018
Compare
I like @talldan's wording, and have minor suggestions for that whole area -- some capitalization fixes, some rephrasing.
|
@michelleweber Thanks for the suggestions! Currently, the Experiment page is like this: It's not completely different, but a couple of experiments changed. I can incorporate your suggestions in this PR, so I'm just double checking in case you wish to improve the copy of the new experiments too. 🙂 |
Ah, gotcha! Yes, there are some small changes, just to capitalization, that we should make in the current copy:
|
248a4ea
to
6b0c8f6
Compare
Thanks @michelleweber! I've updated the strings as per your suggestions and removed the Needs Copy Review label. 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks @Copons and @michelleweber!
Hi, don't know if this is the right place to ask, but can someone clarify what "potentially irreversible changes" these are referring to? From what I can tell, everything is reverted back when the FSE is turned off? |
Description
Testing instructions
Open
/wp-admin/admin.php?page=gutenberg-experiments
and make sure it looks fine.