Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook: Add stories for Checkbox control component #17891

Merged
merged 14 commits into from
Oct 16, 2019
Merged

Storybook: Add stories for Checkbox control component #17891

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7291d94
Add checkbox control stories for Storybook
mkaz Oct 10, 2019
98fa807
Update README example to match story, useState
mkaz Oct 10, 2019
aadf374
Apply suggestions from code review
mkaz Oct 14, 2019
bcf27f1
Update story to match README
mkaz Oct 15, 2019
a7ab3c5
Add variants for heading, label, help
mkaz Oct 15, 2019
df5d50f
Update packages/components/src/checkbox-control/README.md
mkaz Oct 15, 2019
506de84
Add Knobs addon to Storybook
mkaz Oct 15, 2019
c8f128a
Move storybook addon to dev-dependencies
mkaz Oct 15, 2019
9f1b5cc
Solve lint dependency by excluding stories, dont need in package.json
mkaz Oct 15, 2019
b8fdd69
Apply suggestions from code review
mkaz Oct 15, 2019
dafbed6
Update with story level decorators
mkaz Oct 15, 2019
1583774
Switch back to global withKnobs, per story not working
mkaz Oct 16, 2019
cd84a53
Change the name of the example in ChecboxControl story
gziolo Oct 16, 2019
bbcd3bf
Try with the uppercase name of the component exported from stories
gziolo Oct 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ module.exports = {
'**/*.@(android|ios|native).js',
'**/benchmark/**/*.js',
'**/@(__mocks__|__tests__|test)/**/*.js',
'**/storybook/**/*.js',
'**/@(storybook|stories)/**/*.js',
],
},
{
Expand Down
Loading