Core Data: Clear auto-draft titles on save if not changed explicitly. #17633
Conversation
|
Worth expanding E2E tests? |
|
(thanks for the quick dive into this!) |
|
Yeah, added one here: c30ed80 |
| if ( ! data.status ) { | ||
| data = { ...data, status: 'draft' }; | ||
| } | ||
| if ( ! data.title || data.title === 'Auto Draft' ) { |
There was a problem hiding this comment.
Should Auto Draft be put through a translation function? It is translated in get_default_post_to_edit(). Not 100% sure if that is the same place the post title is getting set in Gutenberg.
There was a problem hiding this comment.
How does that relate to this change? We are clearing the title here.
There was a problem hiding this comment.
Well it compares the title with an English string, which might not work on a localized environment
There was a problem hiding this comment.
Got it.
So is "Auto Draft" translated in this context? Where would we check?
There was a problem hiding this comment.
Yes, as that string is coming from get_default_post_to_edit().
So you'd need to compare it with __( 'Auto Draft' ), not just 'Auto Draft'
There was a problem hiding this comment.
It looks like it is. I just tried @swissspidy's replication steps on trunk in a non-english locale, and the title was set to Automatisch gespeicherter Entwurf on publish.
There was a problem hiding this comment.
I'm trying to replicate it, but data.title is always undefined here unless you explicitly typed in the auto draft title, so the second check doesn't even run.
Fixes #17628
Description
This PR fixes an issue where saving an
auto-draftwithout a title would persist its default title, "Auto Draft", in the newdraftorpublishedpost. The latter two statuses don't have an incoming filter to clear the "Auto Draft" title so it would show in the editor and confuse users.How has this been tested?
It was verified that saving or publishing new posts without titles no longer sets the title to "Auto Draft", but keeps it empty instead.
Types of Changes
Bug Fix: New posts saved or published without a title will no longer have their title set to "Auto Draft".
Checklist: