Add an aria-label to the editor blocks. #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
reviewed
Jun 30, 2017
editor/modes/visual-editor/block.js
Outdated
| @@ -236,6 +237,7 @@ class VisualEditorBlock extends Component { | |||
| render() { | |||
| const { block, multiSelectedBlockUids } = this.props; | |||
| const blockType = getBlockType( block.name ); | |||
| const blockLabel = sprintf( __( 'Editor block: %s' ), blockType.title ); | |||
There was a problem hiding this comment.
Maybe I'd just use Block: %s but I'm fine either way
|
I've simplified the aria label to be just Edit: seems it has already been addressed? /cc @aduth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass to try to add an aria-label to the Editor blocks. Code and wording could be improved, any feedback welcome.
All the editor blocks need to be labeled to allow screen reader users to get
whata block is.Screenshots:
Re: VoiceOver in the screenshot above:
Fixes #562