-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating SlotFill documentation and examples #15738
Updating SlotFill documentation and examples #15738
Conversation
These docs are great, thanks @ryanwelcher! I was thinking, though: what if we add this to a new section in the handbook called "Slot Reference"? I believe it would give them more visibility: it is an important concept that isn't covered in the reference docs yet although we do have a tutorial and component docs. It'd fit well just after the "Filter Reference" section almost verbatim, and the "existing slots" could be subsections that we'd add as new slots are implemented. What do you think? |
@nosolosw that would work for me. One of the issues I'm running into is adding an image for each of the slotsFills because the docs get auto-generated. I've started adding them into the docs now and should have this PR updated soon. |
Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
…ttings-menu-item.md Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
…ttings-menu-item.md Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
…ttings-menu-item.md Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
…lish-panel.md Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
…tus-info.md Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
…ish-panel.md Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
…more-menu-item.md Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
…erg into update/slot-fill-docs
@nosolosw thanks for the review and suggestions on this! |
…more-menu-item.md Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
…more-menu-item.md Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this in and follow-up on the block-editor
SlotFills. I'm merging this as soon as Travis would let us.
This is a great improvement to the handbook, thanks for getting this in @ryanwelcher ! 🌟 |
Awesome work here 👍 |
Glad to help :) |
Description
This PR aims to improve the documentation and examples for SlotFill based on work done in https://github.com/10up/slotfill-and-filter-demos
Types of changes
Documentation
Checklist: