Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RichText: remove DOM logic from list toolbar #14840

Merged
merged 3 commits into from
Apr 10, 2019
Merged

RichText: remove DOM logic from list toolbar #14840

merged 3 commits into from
Apr 10, 2019

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Apr 5, 2019

Description

Follow-up from #14636. Removes DOM logic from the list toolbar by using new functions introduced.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@ellatrix ellatrix added [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Code Quality Issues or PRs that relate to code quality labels Apr 5, 2019
@ellatrix ellatrix requested review from SergioEstevao and hypest April 5, 2019 12:32
@ellatrix ellatrix mentioned this pull request Apr 5, 2019
Merged
1 task
@ellatrix
Copy link
Member Author

ellatrix commented Apr 5, 2019

Added e2e test for wordpress-mobile/WordPress-iOS#11409 (comment).

hypest
hypest approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up @ellatrix , this looks 👍 from the native mobile side.

I've only reviewed the native mobile though so, I'll let others add their reviews too.

@ellatrix ellatrix added the Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code label Apr 5, 2019
@ellatrix ellatrix force-pushed the fix/list-toolbar-dom branch from 1aec480 to 17926a5 Compare April 10, 2019 13:05
@ellatrix
Copy link
Member Author

Going to merge as it's a fairly simple change and a good clean up to have.

@ellatrix ellatrix merged commit 4915243 into master Apr 10, 2019
@ellatrix ellatrix deleted the fix/list-toolbar-dom branch April 10, 2019 13:22
@youknowriad youknowriad added this to the 5.5 (Gutenberg) milestone Apr 12, 2019
mchowning pushed a commit to mchowning/gutenberg that referenced this pull request Apr 15, 2019
@ellatrix @mchowning
RichText: remove DOM logic from list toolbar (WordPress#14840)
5c9d8f8 
* RichText: remove DOM logic from list toolbar

* Fix mobile side

* Add e2e test for ordered split
This was referenced Apr 15, 2019
Merged
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest hypest approved these changes

@SergioEstevao SergioEstevao Awaiting requested review from SergioEstevao

@aduth aduth Awaiting requested review from aduth

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@youknowriad youknowriad Awaiting requested review from youknowriad

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@gziolo gziolo Awaiting requested review from gziolo

@nerrad nerrad Awaiting requested review from nerrad

@ntwb ntwb Awaiting requested review from ntwb

@talldan talldan Awaiting requested review from talldan

Assignees
No one assigned
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
5.5 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
3 participants
@ellatrix @hypest @youknowriad