Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Block Appender as placeholder to empty InnerBlocks #14241

Merged
Merged
Changes from 1 commit
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
842e742
Adds Block Appender as placeholder to empty InnerBlocks
getdave Mar 5, 2019
12e7f5c
Updates to allow InnerBlocks to control it’s placeholder when empty
getdave Mar 6, 2019
4cf6051
Updates Column Block to opt-in to using Block Appender as placeholder
getdave Mar 6, 2019
ea1ea40
Fix edge case where block can be null value
getdave Mar 6, 2019
07557d1
Simplifies wording on Block Appender
getdave Mar 6, 2019
5e648ec
Adds background color to Block Appender
getdave Mar 6, 2019
6470b37
Adds support for dark themes
getdave Mar 7, 2019
1d438c2
Adds keyboard focus support for visual cues
getdave Mar 7, 2019
0a66f77
Fixes comment to approved version
getdave Mar 7, 2019
57a640e
Adjusts background to use lighter colour variant
getdave Mar 12, 2019
88606c2
Adds consistent spacing around appender
getdave Mar 25, 2019
6f1baea
Removes unecessary Fragment usage
getdave Mar 25, 2019
08dc914
Adjusts font weight and space between icon and “Add Block” text
getdave Mar 26, 2019
f736575
Adjusts appender padding to match supplied visual
getdave Mar 26, 2019
30f0922
Aligns appender with sibling Blocks
getdave Mar 26, 2019
606896d
Revert "Aligns appender with sibling Blocks"
getdave Mar 26, 2019
05a1dfc
Updates to use explict and more extenable prop for choosing the place…
getdave Apr 1, 2019
f698f73
Reverts Column to use default placeholder behaviour
getdave Apr 1, 2019
ee2b182
Removes “is passthrough” edge case for Columns
getdave Apr 1, 2019
0b53217
Fixes Columns layout edge case for Block Appender
getdave Apr 1, 2019
536f425
Updates colors for hover and active states
getdave Apr 2, 2019
4abf1f3
Fix docs to show correct variable type
getdave Apr 3, 2019
558771b
Updates to appender rendering to utilise render prop
getdave Apr 5, 2019
b1af612
Adds default appender as explicit constant
getdave Apr 5, 2019
56b87ef
Adds option to hide appender entirely for InnerBlocks if children pre…
getdave Apr 5, 2019
1dc1b8b
Updates documentation for `renderAppender` and `hideAppenderWhenChild…
getdave Apr 5, 2019
a7f0eaa
Updates to remove superflous usage of `appender` suffix
getdave Apr 5, 2019
4fc3918
Fixes Markdown usage on README heading
getdave Apr 5, 2019
78f64fc
Fix to ensure default appender render when default block is not active
getdave Apr 8, 2019
10979e1
Exposes placeholder defaults as components on InnerBlocks
getdave Apr 9, 2019
bd4e2ae
Adds mixins to handle visually hiding content but preserving for scre…
getdave Apr 11, 2019
1df2ca0
Removes the “Add Block” text from the button appender
getdave Apr 11, 2019
f390c55
Adds Button Block Appender component to DRY up component usage
getdave Apr 11, 2019
58cd20a
Removes superfluous enum handling on renderAppender prop
getdave Apr 11, 2019
6a13d86
Minor - updates comments to end in full stops
getdave Apr 11, 2019
b26a5a6
Extracts `hideWhenChildBlocks` component for use on `InnerBlocks`
getdave Apr 11, 2019
d886e56
Updates docs with correct props and usage examples
getdave Apr 11, 2019
39ce905
Add docs for `ButtonBlockAppender` component
getdave Apr 11, 2019
0aaae76
Adds ability to pass custom CSS className to ButtonBlockAppender comp…
getdave Apr 11, 2019
faf147f
Fixes e2e test by ensuring correct className is restored on appender …
getdave Apr 11, 2019
4c0ad0c
Revert "Adds mixins to handle visually hiding content but preserving …
getdave Apr 11, 2019
ff90334
Utilise existing WP Core screen reader text class
getdave Apr 11, 2019
d1efe5c
Removes dependency on compose
getdave Apr 11, 2019
741ccd2
Improves naming of aliased component
getdave Apr 11, 2019
add695c
Capitalise component name
getdave Apr 11, 2019
676bd1b
Correct spelling
getdave Apr 11, 2019
6d19945
Simplifies check for prop
getdave Apr 11, 2019
b36e3a3
Remove `utils` directory and flatten
getdave Apr 11, 2019
bb43af3
Simplify the use of if statements in BlockListAppender
talldan Apr 12, 2019
1dc1ec3
Use classnames utility to concat classes
talldan Apr 12, 2019
267626c
Rename class to block-editor-button-block-appender
talldan Apr 12, 2019
2a5e98b
Switch to either arrow functions assigned to a const or exported func…
talldan Apr 12, 2019
e2f745a
revert unintentional formatting changes
talldan Apr 12, 2019
6f4e295
Remove HideWhenChildBlocks. This will be added on a separate branch
talldan Apr 12, 2019
13d243a
Tidy up docs
talldan Apr 12, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reverts Column to use default placeholder behaviour
As discuseed, removing this from Column to facilitate merge.
  • Loading branch information
getdave authored and talldan committed Apr 12, 2019
commit f698f73adcd2278bd09caad9358a0eaafc9be0be
1 change: 0 additions & 1 deletion packages/block-library/src/column/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ const ColumnEdit = ( { attributes, updateAlignment } ) => {
/>
</BlockControls>
<InnerBlocks
placeholderType={ 'block-appender' }
templateLock={ false }
/>
</div>
Expand Down