-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL input popover visual cleanup #13973
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
47acdb2
Use chevron instead of ellipsis in url input field options.
kjellr a35b7a7
Mimic toolbar icon styles for the icons in the URL popover.
kjellr 6cdf20b
Add a left divider before the URL settings toggle
kjellr 3fb56cd
Even up the spacing in the settings panel.
kjellr b12a17f
Add periods to code comments.
kjellr 02acf7e
Update snapshot
kjellr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add a left divider before the URL settings toggle
- Loading branch information
commit 6cdf20b33bd094f1b6b4dfa4e6513ce9fe7e610b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you didn't write this initially, but while you're here do you think we should change this rule to be less obtuse? Although there isn't any written rule saying this much, in general I believe the SCSS standard pattern that is emerging is to use write
.editor-url-popover__settings-toggle
rather than.editor-url-popover { &__settings-toggle { ... } }
.Hmm actually that might be a big rewrite of this CSS file. Okay to ignore if you feel this is too big of a task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed! This was really confusing to parse. I'll take care of this in a separate PR, so we can get this change in first. 👍