Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Missing margin in blocks with child blocks #13227

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Fix: Missing margin in blocks with child blocks #13227

merged 1 commit into from
Jan 9, 2019

Conversation

jorgefilipecosta
Copy link
Member

Description

Fixes: #13010

A margin was missing for the parent block on the inserter child blocks area.
This PR just adds a small margin.

How has this been tested?

I added the test block available in https://gist.github.com/jorgefilipecosta/60a0bf242e8c7c18805618558268315d.
I inserted the parent block, I used the sibling inserter inside the parent block and I verified a small margin appears between the parent block icon and the block name.

Screenshots

Before:
screenshot 2019-01-07 at 16 42 20
After:
screenshot 2019-01-07 at 16 42 00

@jorgefilipecosta jorgefilipecosta added the [Type] Bug An existing feature does not function as intended label Jan 8, 2019
jasmussen
jasmussen approved these changes Jan 8, 2019
View reviewed changes
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Can you make it use $grid-size-small (4px) instead of 5px? Or even $grid-size (8px) if that looks good.

@jorgefilipecosta jorgefilipecosta force-pushed the fix/add-margin-to-blocks-with-child-blocks branch from 19644d2 to 2fe7878 Compare January 8, 2019 16:37
@jorgefilipecosta
Copy link
Member Author

Thank you for the review @jasmussen.
I like the result using $grid-size (8px), and I updated the code.
Here are two screenshots one a complex icon with SVG and background color, and another one a simple icon:
screenshot 2019-01-08 at 16 35 17
screenshot 2019-01-08 at 16 36 52

@jorgefilipecosta jorgefilipecosta added this to the 4.9 milestone Jan 8, 2019
@jasmussen
Copy link
Contributor

I think that's good! Ship it.

@youknowriad youknowriad merged commit 6ad03d5 into master Jan 9, 2019
@youknowriad youknowriad deleted the fix/add-margin-to-blocks-with-child-blocks branch January 9, 2019 09:04
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@jorgefilipecosta @youknowriad
Fix: Missing margin in blocks with child blocks (#13227)
1459f5b
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@jorgefilipecosta @youknowriad
Fix: Missing margin in blocks with child blocks (#13227)
9811d08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasmussen jasmussen jasmussen approved these changes

Assignees
No one assigned
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
4.9 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgefilipecosta @jasmussen @youknowriad