Added missing "Code is Poetry" block in some packages #13101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
requested changes
Jan 4, 2019
| @@ -27,3 +27,5 @@ count accepts three parameters: | |||
| ```JS | |||
| import { count } from '@wordpress/wordcount'; | |||
| const numberOfWords = count( 'Words to count', 'words', {} ) | |||
|
|
|||
| <br/><br/><p align="center"><img src="https://s.w.org/style/images/codeispoetry.png?1" alt="Code is Poetry." /></p> | |||
There was a problem hiding this comment.
This does not display correctly, as the prior code block is not terminated.
There was a problem hiding this comment.
@aduth added end tag of JS "````"
There was a problem hiding this comment.
There should only be three back ticks to end the block. It does seem to display correctly in the preview though, which is unexpected to me.
There was a problem hiding this comment.
@aduth thanks for your guidance
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* docs: added correct name for font site 50 * Remove old changes * Added missing "Code is Poetry" block in some packages documents * Revert "Remove old changes" This reverts commit c7622d9. * Revert "docs: added correct name for font site 50" This reverts commit b30c96a. * Fix display issue in wordcount package * Fix end tag for js block
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* docs: added correct name for font site 50 * Remove old changes * Added missing "Code is Poetry" block in some packages documents * Revert "Remove old changes" This reverts commit c7622d9. * Revert "docs: added correct name for font site 50" This reverts commit b30c96a. * Fix display issue in wordcount package * Fix end tag for js block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of the package documents of gutenberg handbook are missing "Code is Poetry" block at the end of the page.