Add: End 2 End tests on the sidebar permalink editor for CPT's. #13060
Conversation
| @@ -0,0 +1,45 @@ | |||
| <?php | |||
| /** | |||
| * Plugin Name: Gutenberg Test Custom CPTS | |||
There was a problem hiding this comment.
Does CPTS stand for Custom Post Types? I dunno what it stands for so we should probably explain it 😄
|
|
||
|
|
||
| add_action( 'init', function() { | ||
| register_post_type( 'public_q_public', [ |
There was a problem hiding this comment.
It might be easier to read these/the test suites if these were expanded a bit. Maybe:
view_public_query_publicview_notPublic_query_public
etc...
| * @package gutenberg-test-custom-cpts | ||
| */ | ||
|
|
||
| add_action( 'init', function() { |
There was a problem hiding this comment.
Looks like there are a bunch of PHPCS errors here. Are these spaces you're using?! 😉
|
Oops, thanks for the further indent fixes; I was just guessing. The PHPCS rules are kinda odd to me 😄 |
19a1c59 to
aabfc58
Compare
aabfc58 to
5aad5bb
Compare
|
Thank you for the review @tofumatt all the feedback was applied before the merge. While I was editing the commit title I pressed enter by error and the commit got a wrong title, I'm sorry for that :( |
I've been there before many times; no worries 😆 |
Description
This PR adds a series of tests testing if the sidebar panel should appear in several different combinations of CPT's containing different values for public and public queryable.
Should have failed on the bug #12482 meanwhile solved on #12884.
How has this been tested?
I execute the end 2 end tests and verified they pass.