-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improve empty block text #11560
Changes from 6 commits
1a747fc
33a7a9a
3d1e777
4f11648
41e5a28
8103e71
a2c2cac
2bf0f30
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -71,7 +71,7 @@ export class PostTextEditor extends Component { | |
return ( | ||
<Fragment> | ||
<label htmlFor={ `post-content-${ instanceId }` } className="screen-reader-text"> | ||
{ decodedPlaceholder || __( 'Write your story' ) } | ||
{ decodedPlaceholder || __( 'Type text' ) } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's remove the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sounds good; if that means this is otherwise good to go mind explicitly reviewing it now? 😄 |
||
</label> | ||
<Textarea | ||
autoComplete="off" | ||
|
@@ -80,7 +80,7 @@ export class PostTextEditor extends Component { | |
onBlur={ this.stopEditing } | ||
className="editor-post-text-editor" | ||
id={ `post-content-${ instanceId }` } | ||
placeholder={ decodedPlaceholder || __( 'Write your story' ) } | ||
placeholder={ decodedPlaceholder || __( 'Type text' ) } | ||
/> | ||
</Fragment> | ||
); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should "type text" be replaced with "start writing"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a screen reader I actually think "type text" is better than "start writing".