[WP 6.1] Block Styles in theme.json do not appear in the Editor or Frontend #44619

ndiego · 2022-09-30T17:37:44Z

Description

When Gutenberg is not active, block styles in theme.json are not getting rendered in the Editor or Frontend in WordPress 6.1 Beta 2. Activating Gutenberg solves this, so perhaps something has not been properly ported back to Core.

Also seems like it might be related to: #44434

Step-by-step reproduction instructions

Use WordPress 6.1 Beta 2 and the new TT3 theme
Ensure Gutenberg is not active
Add the sample code to block styles in theme.json (not needed but makes the issue more clear)
Add a new page and add a Code, Group, and Pullquote
See that the custom block styles in theme.json are not applied in both the Editor and Frontend
Now activate Gutenberg and see that everything works correctly

"core/code": {
	"color": {
		"background": "var(--wp--preset--color--secondary)",
		"text": "var(--wp--preset--color--base)"
	},
	"spacing": {
		"padding": {
			"bottom": "var(--wp--preset--spacing--30)",
			"left": "var(--wp--preset--spacing--30)",
			"right": "var(--wp--preset--spacing--30)",
			"top": "var(--wp--preset--spacing--30)"
		}
	},
	"typography": {
		"fontSize": "var(--wp--preset--font-size--small)"
	}
},
"core/group": {
	"color": {
		"background": "var(--wp--preset--color--secondary)",
		"text": "var(--wp--preset--color--base)"
	},
	"spacing": {
		"padding": {
			"bottom": "var(--wp--preset--spacing--30)",
			"left": "var(--wp--preset--spacing--30)",
			"right": "var(--wp--preset--spacing--30)",
			"top": "var(--wp--preset--spacing--30)"
		}
	},
	"typography": {
		"fontSize": "var(--wp--preset--font-size--small)"
	}
},

Screenshots, screen recording, code snippet

Without Gutenberg active:

With Gutenberg active:

Environment info

WordPress 6.1 Beta 2
Gutenberg NOT active

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

The text was updated successfully, but these errors were encountered:

bph · 2022-09-30T19:17:39Z

@ndiego I can confirm this bug with a clean installation of the WordPress 6.1 beta 2 version.

mikachan · 2022-09-30T19:55:45Z

I can also replicate this with TT3 and another theme called Archeo, using the same test instructions above.

andrewserong · 2022-10-02T23:28:59Z

Also seems like it might be related to: #44434

Just confirming that yes, I think this is the same underlying issue — just noticed from a different perspective 🙂
I believe the proposed fix in WordPress/wordpress-develop#3373 should resolve both issues.

ockham · 2022-10-04T11:48:23Z

If I'm not mistaken, this can also be reproduced with TT2 (with no changes to theme.json).

To test, insert some button blocks and view on the frontend. They should be rectangular, with a dark green background (rather than round and black).

Actual (broken)	Expected (correct)

(via WordPress/wordpress-develop#3352)

ockham · 2022-10-05T11:14:41Z

I've filed https://core.trac.wordpress.org/ticket/56736 to reflect this issue in Core.

ockham · 2022-10-05T13:44:29Z

I've filed a tentative fix over at WordPress/wordpress-develop#3408.

oandregal · 2022-10-07T09:53:49Z

I cannot longer reproduce this bug with latest trunk.

ockham · 2022-10-07T11:48:08Z

I cannot longer reproduce this bug with latest trunk.

Thank you for verifying @oandregal!

Closing, as this has now been fixed by WordPress/wordpress-develop#3408.

A significant performance regression was added late in WP 6.1 beta cycle when some of the existing caching for `theme.json` processing was removed. The rationale for removing the caching was this code was now used before all the blocks are registered (aka get template data, etc.) and resulted in stale cache that created issues (see [WordPress/gutenberg#44434 Gutenberg Issue 44434] and [WordPress/gutenberg#44619 Gutenberg Issue 44619]). The changes were limited to only reads from the file system. However, it introduced a big impact in performance. This commit adds caching and checks for blocks with different origins. How? It add caching for the calculated data for core, theme, and user based on the blocks that are registered. If the blocks haven't changed since the last time they were calculated for the origin, the cached data is returned. Otherwise, the data is recalculated and cached. Essentially, this brings back the previous cache, but refreshing it when the blocks change. It partially adds unit tests for these changes. Additional tests will be added. References: * [WordPress/gutenberg#44772 Performance regression in WP 6.1 for theme.json processing] Follow-up to [54251], [54399]. Props aristath, oandregal, bernhard-reiter, spacedmonkey, hellofromTonya. See #56467. git-svn-id: https://develop.svn.wordpress.org/trunk@54493 602fd350-edb4-49c9-b593-d223f7449a82

A significant performance regression was added late in WP 6.1 beta cycle when some of the existing caching for `theme.json` processing was removed. The rationale for removing the caching was this code was now used before all the blocks are registered (aka get template data, etc.) and resulted in stale cache that created issues (see [WordPress/gutenberg#44434 Gutenberg Issue 44434] and [WordPress/gutenberg#44619 Gutenberg Issue 44619]). The changes were limited to only reads from the file system. However, it introduced a big impact in performance. This commit adds caching and checks for blocks with different origins. How? It add caching for the calculated data for core, theme, and user based on the blocks that are registered. If the blocks haven't changed since the last time they were calculated for the origin, the cached data is returned. Otherwise, the data is recalculated and cached. Essentially, this brings back the previous cache, but refreshing it when the blocks change. It partially adds unit tests for these changes. Additional tests will be added. References: * [WordPress/gutenberg#44772 Performance regression in WP 6.1 for theme.json processing] Follow-up to [54251], [54399]. Props aristath, oandregal, bernhard-reiter, spacedmonkey, hellofromTonya. See #56467. Built from https://develop.svn.wordpress.org/trunk@54493 git-svn-id: http://core.svn.wordpress.org/trunk@54052 1a063a9b-81f0-0310-95a4-ce76da25c4cd

A significant performance regression was added late in WP 6.1 beta cycle when some of the existing caching for `theme.json` processing was removed. The rationale for removing the caching was this code was now used before all the blocks are registered (aka get template data, etc.) and resulted in stale cache that created issues (see [WordPress/gutenberg#44434 Gutenberg Issue 44434] and [WordPress/gutenberg#44619 Gutenberg Issue 44619]). The changes were limited to only reads from the file system. However, it introduced a big impact in performance. This commit adds caching and checks for blocks with different origins. How? It add caching for the calculated data for core, theme, and user based on the blocks that are registered. If the blocks haven't changed since the last time they were calculated for the origin, the cached data is returned. Otherwise, the data is recalculated and cached. Essentially, this brings back the previous cache, but refreshing it when the blocks change. It partially adds unit tests for these changes. Additional tests will be added. References: * [WordPress/gutenberg#44772 Performance regression in WP 6.1 for theme.json processing] Follow-up to [54251], [54399]. Props aristath, oandregal, bernhard-reiter, spacedmonkey, hellofromTonya. See #56467. Built from https://develop.svn.wordpress.org/trunk@54493 git-svn-id: https://core.svn.wordpress.org/trunk@54052 1a063a9b-81f0-0310-95a4-ce76da25c4cd

A significant performance regression was added late in WP 6.1 beta cycle when some of the existing caching for `theme.json` processing was removed. The rationale for removing the caching was this code was now used before all the blocks are registered (aka get template data, etc.) and resulted in stale cache that created issues (see [WordPress/gutenberg#44434 Gutenberg Issue 44434] and [WordPress/gutenberg#44619 Gutenberg Issue 44619]). The changes were limited to only reads from the file system. However, it introduced a big impact in performance. This commit adds caching and checks for blocks with different origins. How? It add caching for the calculated data for core, theme, and user based on the blocks that are registered. If the blocks haven't changed since the last time they were calculated for the origin, the cached data is returned. Otherwise, the data is recalculated and cached. Essentially, this brings back the previous cache, but refreshing it when the blocks change. It partially adds unit tests for these changes. Additional tests will be added. References: * [WordPress/gutenberg#44772 Performance regression in WP 6.1 for theme.json processing] Follow-up to [54251], [54399]. Props aristath, oandregal, bernhard-reiter, spacedmonkey, hellofromTonya. See #56467. git-svn-id: https://develop.svn.wordpress.org/trunk@54493 602fd350-edb4-49c9-b593-d223f7449a82

ndiego added [Type] Bug An existing feature does not function as intended [Priority] High Used to indicate top priority items that need quick attention Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Sep 30, 2022

ndiego added this to WordPress 6.1 Editor Tasks Sep 30, 2022

ndiego moved this to Triage in WordPress 6.1 Editor Tasks Sep 30, 2022

ndiego changed the title ~~[WP 6.1] Block Styles in theme.json not appear in the Editor of Frontend~~ [WP 6.1] Block Styles in theme.json do not appear in the Editor of Frontend Sep 30, 2022

ndiego changed the title ~~[WP 6.1] Block Styles in theme.json do not appear in the Editor of Frontend~~ [WP 6.1] Block Styles in theme.json do not appear in the Editor or Frontend Sep 30, 2022

ndiego mentioned this issue Sep 30, 2022

Theme JSON and Resolver: Update block caching logic to clear based on number of registered blocks WordPress/wordpress-develop#3373

Closed

ndiego moved this from Triage to Todo in WordPress 6.1 Editor Tasks Oct 3, 2022

ajlende mentioned this issue Oct 3, 2022

Avoid calling get_blocks_metadata in WP_Theme_JSON constructor #44658

Merged

glendaviesnz moved this from Todo to In Progress in WordPress 6.1 Editor Tasks Oct 4, 2022

ockham mentioned this issue Oct 4, 2022

[WP 6.1] Block-specific global styles don't seem to save #44434

Closed

cbravobernal mentioned this issue Oct 4, 2022

Try to cache the theme json file reading WordPress/wordpress-develop#3401

Closed

ockham mentioned this issue Oct 4, 2022

WP_Theme_JSON: Invalidate blocks metadata cache when needed WordPress/wordpress-develop#3359

Closed

oandregal mentioned this issue Oct 7, 2022

Performance regression in WP 6.1 for theme.json processing #44772

Closed

ockham closed this as completed Oct 7, 2022

Repository owner moved this from In Progress to Done in WordPress 6.1 Editor Tasks Oct 7, 2022

oandregal mentioned this issue Oct 7, 2022

Improve caching for theme.json processing WordPress/wordpress-develop#3418

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WP 6.1] Block Styles in theme.json do not appear in the Editor or Frontend #44619

[WP 6.1] Block Styles in theme.json do not appear in the Editor or Frontend #44619

ndiego commented Sep 30, 2022

bph commented Sep 30, 2022

mikachan commented Sep 30, 2022

andrewserong commented Oct 2, 2022

ockham commented Oct 4, 2022

ockham commented Oct 5, 2022

ockham commented Oct 5, 2022

oandregal commented Oct 7, 2022 •

edited

Loading

ockham commented Oct 7, 2022

[WP 6.1] Block Styles in theme.json do not appear in the Editor or Frontend #44619

[WP 6.1] Block Styles in theme.json do not appear in the Editor or Frontend #44619

Comments

ndiego commented Sep 30, 2022

Description

Step-by-step reproduction instructions

Screenshots, screen recording, code snippet

Environment info

Please confirm that you have searched existing issues in the repo.

Please confirm that you have tested with all plugins deactivated except Gutenberg.

bph commented Sep 30, 2022

mikachan commented Sep 30, 2022

andrewserong commented Oct 2, 2022

ockham commented Oct 4, 2022

ockham commented Oct 5, 2022

ockham commented Oct 5, 2022

oandregal commented Oct 7, 2022 • edited Loading

ockham commented Oct 7, 2022

oandregal commented Oct 7, 2022 •

edited

Loading