Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink movers/trash/ellipsis on mobile #4084

Closed
jasmussen opened this issue Dec 19, 2017 · 1 comment · Fixed by #4101
Closed

Rethink movers/trash/ellipsis on mobile #4084

jasmussen opened this issue Dec 19, 2017 · 1 comment · Fixed by #4101
Labels
Mobile Web Viewport sizes for mobile and tablet devices Needs Design Feedback Needs general design feedback.

Comments

@jasmussen
Copy link
Contributor

To the left and right of a selected or hovered block, we have some quick tools. The mover, on the left, lets you move a block up or down. The ellipsis on the right holds more advanced tools, such as a shortcut to settings or editing the HTML of a block.

On mobile, we do not have room to show these on the side of a block, and there's no hover either. Currently in master, we solved this by putting those tools inside an ellipsis menu. But this is inelegant — there are already ellipses elsewhere, and more importantly this ellipsis behaves differently than the one you see on the desktop. That's not a good interface.

Let's consider a different interface for showing these quick-tools on mobile. This is inspired by a concept by @iamthomasbishop (Thank you! 🏅 )

Mockups

When viewing text, you'd see this:

mobile block unselected

Tapping a block, you'd then pop out the mover, a trash button, and an ellipsis button below the contents of the block itself, same as how a caption field pops out when you select an image:

mobile block selected

When you tap the ellipsis in that situation, you could see a modal popover instead of the flyout menu:

mobile ellipsis pressed

☝️ that last part, the modal popover, would be an optional enhancement. The key here is the mover, the trash button, and the ellipsis appear on tapping the block.

@jasmussen jasmussen added Design Needs Design Feedback Needs general design feedback. Mobile Web Viewport sizes for mobile and tablet devices labels Dec 19, 2017
@karmatosed
Copy link
Member

+1 to getting this in. It's important that we improve the experience on mobile. I like all of this 🚢 it :)

jasmussen pushed a commit that referenced this issue Dec 20, 2017
Those controls include the mover and the ellipsis menu. As such, this PR fixes #4084.

What this PR does, is remove all mobile tools from the quick toolbar, and instead shows these tools inline at the bottom of a _selected_ block.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile Web Viewport sizes for mobile and tablet devices Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants