Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grey gap at bottom of screen when scrolling #27157

Closed
karmatosed opened this issue Nov 20, 2020 · 3 comments · Fixed by #27253
Closed

Grey gap at bottom of screen when scrolling #27157

karmatosed opened this issue Nov 20, 2020 · 3 comments · Fixed by #27253
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@karmatosed
Copy link
Member

karmatosed commented Nov 20, 2020

Currently when you scroll the following is seen - using Firefox:

2020-11-20 15 12 40

This looks like it's not happening until the following PR.

The solution is to not have the gap, I will investigate this in a PR, but posting as it's existing issue and initially didn't fix by doing a simple revert on my install so creating this issue for deeper investigation.

Props @jasmussen for noting this.

@karmatosed karmatosed added the [Type] Bug An existing feature does not function as intended label Nov 20, 2020
@tellthemachines
Copy link
Contributor

I don't think this was caused by #26944, because that one was backported to 5.6 and this issue isn't happening on 5.6 RC1.

I supect the culprit to be #27035, particularly this line that applies height: 100% to block-editor-writing-flow__click-redirect (if the height is applied only to editor-styles-wrapper the issue disappears).

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 23, 2020
@jasmussen
Copy link
Contributor

Created a fix in #27187.

@karmatosed
Copy link
Member Author

karmatosed commented Nov 23, 2020

Ah @tellthemachines the backporting makes sense why I was having issue tracking this down, thank you so much for context there. Time travelling back through PRs got me there but it now makes sense why it was misleading - sorry poor PR it wasn't your fault!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
4 participants