Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New form controls CSS rules conflict with the metaboxes and custom fields areas #16838

Closed
afercia opened this issue Jul 31, 2019 · 4 comments
Closed
Labels
[Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jul 31, 2019

Splitting this out from #14509 (comment)

With the change made on #14509, the Gutenberg CSS rules for its form controls now target also any form controls within the metaboxes area and the custom fields area.

See for example Yoast/wordpress-seo#13316

The reason is simple:

  • before: all the input rules were scoped to specific parts of the Gutenberg UI:
.editor-post-permalink,
.edit-post-sidebar,
.editor-post-publish-panel,
.block-editor-block-list__block,
.components-popover,
.components-modal__content 
  • after: they're in the new mixin which is scoped to .block-editor and .block-editor is the Gutenberg main container, which includes both the metaboxes and custom fields areas.

In other words, this is a breaking change because it will likely break User Interfaces provided by plugins. It should either be communicated to plugin authors well in advance so they can adjust their CSS or (preferably) the new mixin should be better scoped.

@afercia afercia added the [Type] Bug An existing feature does not function as intended label Jul 31, 2019
@paaljoachim
Copy link
Contributor

Is this issue still valid?

@joedolson Joe. I am pinging you in again. Thanks.

@joedolson
Copy link
Contributor

This is outside of the accessibility scope, so I'm not going to do a lot of investigation; but given that this is an issue with a breaking change that appears to be 18 months old, I would assume that developers will have worked around it by now. Might be closed by #16856

@paaljoachim
Copy link
Contributor

I'll also ping @tellthemachines Isabel as well. Just to be sure.

@tellthemachines
Copy link
Contributor

Yup, #16856 fixed the issue. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants