-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File Block: Consider removing the toggle control help text under the "Show Download Button" toggle. #13429
Comments
Pinging @afercia, since I vaguely recall that this text was added due to accessibility concerns, if I am not mistaken. |
See the lengthy discussion on #2146 which was closed without consensus. From an accessibility perspective, the accessibility team asked to have a textual representation of the toggle state. An On/Off was enough. Instead, in many cases the help text was used as sort of lengthier "dynamic" description. Currently there's some inconsistency across all these toggles. I'd be in favor of removing inappropriate (slightly redundant) text but: graphics is not enough, there need to be some text to indicate the state. |
For clarity's sake, do you agree that this specific instance is a bit redundant and could be removed? It sounds like you're suggesting there might need to be a different text-based description here instead. If so, any suggestions? Thank you for your input! |
I'd agree this specific wording is redundant but there should be an |
As per discussion in #13429, this help text is redundant and can be removed. There's still some discussion to be had about adding some sort of "on/off" text to clarify the state for toggles like this, but that should be tackled globally.
As per discussion in #13429, this help text is redundant and can be removed. There's still some discussion to be had about adding some sort of "on/off" text to clarify the state for toggles like this, but that should be tackled globally.
As per discussion in #13429, this help text is redundant and can be removed. There's still some discussion to be had about adding some sort of "on/off" text to clarify the state for toggles like this, but that should be tackled globally.
As per discussion in #13429, this help text is redundant and can be removed. There's still some discussion to be had about adding some sort of "on/off" text to clarify the state for toggles like this, but that should be tackled globally.
The "Show Download Button" toggle for the File block comes with some helper text to explain the current state:
There are many instances where supplementary text is helpful (For instance, we use that text to explain what a drop cap is for the paragraph block).
In the case of the file block's download button however, this text is simply a readout of the toggle button's state. It seems redundant and we should consider removing it.
The text was updated successfully, but these errors were encountered: