Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The comment delimiter link in Developer's Handbook doesn't exist. #12988

Closed
andreilupu opened this issue Dec 18, 2018 · 2 comments
Closed

The comment delimiter link in Developer's Handbook doesn't exist. #12988

andreilupu opened this issue Dec 18, 2018 · 2 comments
Assignees
@mkaz
Labels
[Type] Developer Documentation Documentation for developers

Comments

@andreilupu
Copy link
Contributor

Describe the bug
The link for the comment delimiter doesn't work in https://wordpress.org/gutenberg/handbook/designers-developers/developers/block-api/block-attributes/.
@swissspidy swissspidy added the [Type] Developer Documentation Documentation for developers label Dec 18, 2018
@swissspidy
Copy link
Member

Hmm https://wordpress.org/gutenberg/handbook/designers-developers/key-concepts/#delimiters-and-parsing-expression-grammar might be the correct one for that.

@chrisvanpatten
Copy link
Contributor

Good catch, we consolidated some documentation into a key concepts page. I'll get that updated

mkaz added a commit that referenced this issue Jan 9, 2019
@mkaz
Fix link to comment delimiters
b977485 
Fixes #12988
@mkaz mkaz mentioned this issue Jan 9, 2019
Merged
@mkaz mkaz self-assigned this Jan 9, 2019
Soean pushed a commit that referenced this issue Jan 9, 2019
@mkaz @Soean
Fix link to comment delimiters in documentation (#13253)
ce864a6 
* Fix link to comment delimiters

Fixes #12988

* One more level
youknowriad pushed a commit that referenced this issue Mar 6, 2019
@mkaz @youknowriad
Fix link to comment delimiters in documentation (#13253)
2ce3b9e 
* Fix link to comment delimiters

Fixes #12988

* One more level
youknowriad pushed a commit that referenced this issue Mar 6, 2019
@mkaz @youknowriad
Fix link to comment delimiters in documentation (#13253)
3ee3d9d 
* Fix link to comment delimiters

Fixes #12988

* One more level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkaz mkaz

Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mkaz @swissspidy @chrisvanpatten @andreilupu