Remove getEditedPostStatus selector

In favor of direct `getEditedPostAttribute( state, 'status' )`
WordPress · Jun 2, 2017 · db75748 · db75748
1 parent 6f8b9de
commit db75748
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 45 deletions.
diff --git a/editor/selectors.js b/editor/selectors.js
@@ -109,17 +109,6 @@ export function getEditedPostAttribute( state, attributeName ) {
 		: state.editor.edits[ attributeName ];
 }
 
-/**
- * Returns the current status of the post being edited, preferring the unsaved
- * value if different than the saved post.
- *
- * @param  {Object} state Global application state
- * @return {String}       Post status
- */
-export function getEditedPostStatus( state ) {
-	return getEditedPostAttribute( state, 'status' );
-}
-
 /**
  * Returns the current visibility of the post being edited, preferring the
  * unsaved value if different than the saved post. The return value is one of
@@ -129,7 +118,7 @@ export function getEditedPostStatus( state ) {
  * @return {String}       Post visiblity
  */
 export function getEditedPostVisibility( state ) {
-	const status = getEditedPostStatus( state );
+	const status = getEditedPostAttribute( state, 'status' );
 	const password = getEditedPostAttribute( state, 'password' );
 
 	if ( status === 'private' ) {

diff --git a/editor/sidebar/post-status/index.js b/editor/sidebar/post-status/index.js
@@ -17,7 +17,7 @@ import './style.scss';
 import PostVisibility from '../post-visibility';
 import PostTrash from '../post-trash';
 import PostSchedule from '../post-schedule';
-import { getEditedPostStatus, getSuggestedPostFormat } from '../../selectors';
+import { getEditedPostAttribute, getSuggestedPostFormat } from '../../selectors';
 import { editPost } from '../../actions';
 
 class PostStatus extends Component {
@@ -71,7 +71,7 @@ PostStatus.instances = 1;
 
 export default connect(
 	( state ) => ( {
-		status: getEditedPostStatus( state ),
+		status: getEditedPostAttribute( state, 'status' ),
 		suggestedFormat: getSuggestedPostFormat( state ),
 	} ),
 	( dispatch ) => {

diff --git a/editor/sidebar/post-visibility/index.js b/editor/sidebar/post-visibility/index.js
@@ -17,7 +17,6 @@ import { Component } from 'element';
 import './style.scss';
 import {
 	getEditedPostAttribute,
-	getEditedPostStatus,
 	getEditedPostVisibility,
 } from '../../selectors';
 import { editPost } from '../../actions';
@@ -124,7 +123,7 @@ class PostVisibility extends Component {
 
 export default connect(
 	( state ) => ( {
-		status: getEditedPostStatus( state ),
+		status: getEditedPostAttribute( state, 'status' ),
 		visibility: getEditedPostVisibility( state ),
 		password: getEditedPostAttribute( state, 'password' ),
 	} ),

diff --git a/editor/test/selectors.js b/editor/test/selectors.js
@@ -15,7 +15,6 @@ import {
 	isEditedPostDirty,
 	getCurrentPost,
 	getPostEdits,
-	getEditedPostStatus,
 	getEditedPostTitle,
 	getEditedPostExcerpt,
 	getEditedPostVisibility,
@@ -195,34 +194,6 @@ describe( 'selectors', () => {
 		} );
 	} );
 
-	describe( 'getEditedPostStatus', () => {
-		it( 'should return the post saved status if the status is not edited', () => {
-			const state = {
-				currentPost: {
-					status: 'draft',
-				},
-				editor: {
-					edits: { title: 'chicken' },
-				},
-			};
-
-			expect( getEditedPostStatus( state ) ).to.equal( 'draft' );
-		} );
-
-		it( 'should return the edited status', () => {
-			const state = {
-				currentPost: {
-					status: 'draft',
-				},
-				editor: {
-					edits: { status: 'pending' },
-				},
-			};
-
-			expect( getEditedPostStatus( state ) ).to.equal( 'pending' );
-		} );
-	} );
-
 	describe( 'getEditedPostTitle', () => {
 		it( 'should return the post saved title if the title is not edited', () => {
 			const state = {