Skip to content

Commit

Permalink
[RNMobile] Bump iOS minimum deployment target to iOS 13.0 (#27577)
Browse files Browse the repository at this point in the history
* Bump deployment target to iOS 13.0

* Bump react-native bridge and aztec deployment target to iOS 13.0

* Remove code specific to iOS versions before 13

* Update changelogs
  • Loading branch information
ceyhun authored Mar 30, 2021
1 parent adc0b38 commit d0fda28
Show file tree
Hide file tree
Showing 10 changed files with 18 additions and 22 deletions.
3 changes: 2 additions & 1 deletion packages/react-native-aztec/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@ For each user feature we should also add a importance categorization label to i
-->

## Unreleased
* [*] Block split/merge fix for a (never shipped) regression (Android only) [#29683]
- [*] Block split/merge fix for a (never shipped) regression (Android only) [#29683]
- [***] Bump minimum deployment target to iOS 13.0 [#27577]
2 changes: 1 addition & 1 deletion packages/react-native-aztec/RNTAztecView.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Pod::Spec.new do |s|
s.source_files = 'ios/RNTAztecView/*.{h,m,swift}'
s.public_header_files = 'ios/RNTAztecView/*.h'
s.requires_arc = true
s.platforms = { :ios => "11.0" }
s.platforms = { :ios => "13.0" }
s.swift_version = '5.0'
s.xcconfig = {'OTHER_LDFLAGS' => '-lxml2',
'HEADER_SEARCH_PATHS' => '/usr/include/libxml2'}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
MTL_ENABLE_DEBUG_INFO = YES;
ONLY_ACTIVE_ARCH = YES;
SDKROOT = iphoneos;
Expand Down Expand Up @@ -341,7 +341,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
MTL_ENABLE_DEBUG_INFO = NO;
SDKROOT = iphoneos;
SWIFT_COMPILATION_MODE = wholemodule;
Expand Down
3 changes: 2 additions & 1 deletion packages/react-native-bridge/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
<!-- Learn how to maintain this file at https://github.com/WordPress/gutenberg/tree/HEAD/packages#maintaining-changelogs. -->

## Unreleased
## Unreleased
- [***] Bump minimum deployment target to iOS 13.0 [#27577]
2 changes: 1 addition & 1 deletion packages/react-native-bridge/Gutenberg.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Pod::Spec.new do |s|
s.homepage = package['homepage']
s.license = package['license']
s.authors = package['author']
s.platform = :ios, '11.0'
s.platform = :ios, '13.0'
s.source = { :git => 'https://github.com/WordPress/gutenberg.git' }
s.source_files = 'ios/**/*.{h,m,swift}'
s.requires_arc = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,7 @@ open class GutenbergWebSingleBlockViewController: UIViewController {
open override func viewDidLoad() {
super.viewDidLoad()
webView.navigationDelegate = self
if #available(iOS 13.0, *) {
isModalInPresentation = true
}
isModalInPresentation = true
addNavigationBarElements()
addCoverView()
loadWebView()
Expand Down Expand Up @@ -110,11 +108,7 @@ open class GutenbergWebSingleBlockViewController: UIViewController {

func addCoverView() {
webView.addSubview(coverView)
if #available(iOS 13.0, *) {
coverView.backgroundColor = UIColor.systemBackground
} else {
coverView.backgroundColor = .white
}
coverView.backgroundColor = UIColor.systemBackground
coverView.translatesAutoresizingMaskIntoConstraints = false
NSLayoutConstraint.activate([
coverView.leadingAnchor.constraint(equalTo: webView.leadingAnchor),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
MTL_ENABLE_DEBUG_INFO = YES;
ONLY_ACTIVE_ARCH = YES;
SDKROOT = iphoneos;
Expand Down Expand Up @@ -223,7 +223,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
MTL_ENABLE_DEBUG_INFO = NO;
SDKROOT = iphoneos;
VALIDATE_PRODUCT = YES;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,7 @@
"$(SRCROOT)/../node_modules/react-native-video/ios/**",
);
INFOPLIST_FILE = GutenbergDemo/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
LIBRARY_SEARCH_PATHS = "$(PROJECT_DIR)";
OTHER_LDFLAGS = (
Expand Down Expand Up @@ -631,7 +631,7 @@
/usr/include/libxml2,
);
INFOPLIST_FILE = GutenbergDemo/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
LIBRARY_SEARCH_PATHS = "$(PROJECT_DIR)";
OTHER_LDFLAGS = (
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-editor/ios/Podfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
project 'GutenbergDemo.xcodeproj'

# Uncomment the next line to define a global platform for your project
platform :ios, '11.0'
platform :ios, '13.0'
require_relative '../../../node_modules/@react-native-community/cli-platform-ios/native_modules'

target 'GutenbergDemo' do
Expand Down
6 changes: 3 additions & 3 deletions packages/react-native-editor/ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ SPEC CHECKSUMS:
FBReactNativeSpec: 118d0d177724c2d67f08a59136eb29ef5943ec75
Folly: 30e7936e1c45c08d884aa59369ed951a8e68cf51
glog: 1f3da668190260b06b429bb211bfbee5cd790c28
Gutenberg: aae81808f86c8efff041d8a987c4f7a84dbedc61
Gutenberg: a6a27f9f3b421da20f0ea091da6779f3ec036696
RCTRequired: b153add4da6e7dbc44aebf93f3cf4fcae392ddf1
RCTTypeSafety: 9aa1b91d7f9310fc6eadc3cf95126ffe818af320
React: b6a59ef847b2b40bb6e0180a97d0ca716969ac78
Expand Down Expand Up @@ -435,10 +435,10 @@ SPEC CHECKSUMS:
RNReanimated: f05baf4cd76b6eab2e4d7e2b244424960b968918
RNScreens: 953633729a42e23ad0c93574d676b361e3335e8b
RNSVG: 46c4b680fe18237fa01eb7d7b311d77618fde31f
RNTAztecView: ec5de892796a349f1195d7965366307200ffdfe8
RNTAztecView: 9fa0a3430874ae395e3e3efa728919c749d6bf9e
WordPress-Aztec-iOS: 870c93297849072aadfc2223e284094e73023e82
Yoga: f2a7cd4280bfe2cca5a7aed98ba0eb3d1310f18b

PODFILE CHECKSUM: fb5a2c8eab8e33d063643370988400ebad0a71d2
PODFILE CHECKSUM: 2629b71d4cbcf6e76c50ab316a3dd51fc0515bc7

COCOAPODS: 1.8.4

0 comments on commit d0fda28

Please sign in to comment.