Serializer: Fix serializing attributes (use HTML format) (#682)

WordPress · May 5, 2017 · cb0a82c · cb0a82c
1 parent 9c67862
commit cb0a82c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/blocks/api/serializer.js b/blocks/api/serializer.js
@@ -59,7 +59,7 @@ export function getCommentAttributes( realAttributes, expectedAttributes ) {
 			return memo;
 		}
 
-		return memo + `${ key }:${ value } `;
+		return memo + `${ key }="${ value }" `;
 	}, '' );
 }
 

diff --git a/blocks/api/test/serializer.js b/blocks/api/test/serializer.js
@@ -71,7 +71,7 @@ describe( 'block serializer', () => {
 				fruit: 'bananas'
 			} );
 
-			expect( attributes ).to.equal( 'category:food ripeness:ripe ' );
+			expect( attributes ).to.equal( 'category="food" ripeness="ripe" ' );
 		} );
 
 		it( 'should not append an undefined attribute value', () => {
@@ -83,7 +83,7 @@ describe( 'block serializer', () => {
 				fruit: 'bananas'
 			} );
 
-			expect( attributes ).to.equal( 'category:food ' );
+			expect( attributes ).to.equal( 'category="food" ' );
 		} );
 	} );
 
@@ -109,7 +109,7 @@ describe( 'block serializer', () => {
 					}
 				}
 			];
-			const expectedPostContent = '<!-- wp:core/test-block align:left -->\n<p>Ribs & Chicken</p>\n<!-- /wp:core/test-block -->\n\n';
+			const expectedPostContent = '<!-- wp:core/test-block align="left" -->\n<p>Ribs & Chicken</p>\n<!-- /wp:core/test-block -->\n\n';
 
 			expect( serialize( blockList ) ).to.eql( expectedPostContent );
 		} );