Try moving the default value to sit under the blockGap key in spacing…

…, updated useCustomSides to support an object
WordPress · May 19, 2022 · a2cc158 · andrewserong · May 19, 2022 · a2cc158
1 parent a9dd741
commit a2cc158
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 8 deletions.
diff --git a/lib/block-supports/layout.php b/lib/block-supports/layout.php
@@ -185,7 +185,7 @@ function gutenberg_render_layout_support_flag( $block_content, $block ) {
 		$gap_value = $gap_value && preg_match( '%[\\\(&=}]|/\*%', $gap_value ) ? null : $gap_value;
 	}
 
-	$fallback_gap_value = _wp_array_get( $block_type->supports, array( 'spacing', '__experimentalDefaultValues', 'blockGap' ), '0.5em' );
+	$fallback_gap_value = _wp_array_get( $block_type->supports, array( 'spacing', 'blockGap', 'default' ), '0.5em' );
 
 	// If a block's block.json skips serialization for spacing or spacing.blockGap,
 	// don't apply the user-defined value to the styles.

diff --git a/packages/block-editor/src/hooks/dimensions.js b/packages/block-editor/src/hooks/dimensions.js
@@ -162,7 +162,7 @@ const useIsDimensionsDisabled = ( props = {} ) => {
  * @param {string} blockName Block name.
  * @param {string} feature   The feature custom sides relate to e.g. padding or margins.
  *
- * @return {Object} Sides supporting custom margin.
+ * @return {string[]} Sides supporting custom margin.
  */
 export function useCustomSides( blockName, feature ) {
 	const support = getBlockSupport( blockName, SPACING_SUPPORT_KEY );
@@ -172,7 +172,13 @@ export function useCustomSides( blockName, feature ) {
 		return;
 	}
 
-	return support[ feature ];
+	if ( Array.isArray( support[ feature ] ) ) {
+		return support[ feature ];
+	}
+
+	if ( support[ feature ]?.sides ) {
+		return support[ feature ].sides;
+	}
 }
 
 /**

diff --git a/packages/block-editor/src/layouts/flex.js b/packages/block-editor/src/layouts/flex.js
@@ -113,8 +113,8 @@ export default {
 		const fallbackValue =
 			getBlockSupport( blockName, [
 				'spacing',
-				'__experimentalDefaultValues',
 				'blockGap',
+				'default',
 			] ) || '0.5em';
 
 		const hasBlockGapStylesSupport = blockGapSupport !== null;

diff --git a/packages/block-library/src/columns/block.json b/packages/block-library/src/columns/block.json
@@ -28,14 +28,13 @@
 			}
 		},
 		"spacing": {
-			"blockGap": true,
+			"blockGap": {
+				"default": "2em"
+			},
 			"margin": [ "top", "bottom" ],
 			"padding": true,
 			"__experimentalDefaultControls": {
 				"padding": true
-			},
-			"__experimentalDefaultValues": {
-				"blockGap": "2em"
 			}
 		},
 		"__experimentalLayout": {