Address a11y feedback

WordPress · Jul 2, 2020 · 77e32a9 · 77e32a9
1 parent e5bc4ec
commit 77e32a9
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 2 deletions.
diff --git a/packages/block-editor/src/components/block-types-list/index.js b/packages/block-editor/src/components/block-types-list/index.js
@@ -19,6 +19,7 @@ function BlockTypesList( {
 	onSelect,
 	onHover = () => {},
 	children,
+	label,
 } ) {
 	const composite = useCompositeState();
 	const normalizedItems = includeVariationsInInserterItems( items );
@@ -31,9 +32,10 @@ function BlockTypesList( {
 		/* eslint-disable jsx-a11y/no-redundant-roles */
 		<Composite
 			as="ul"
-			role="list"
+			role="listbox"
 			{ ...composite }
 			className="block-editor-block-types-list"
+			aria-label={ label }
 		>
 			{ normalizedItems.map( ( item ) => {
 				return (

diff --git a/packages/block-editor/src/components/inserter-list-item/index.js b/packages/block-editor/src/components/inserter-list-item/index.js
@@ -31,7 +31,7 @@ function InserterListItem( {
 		: {};
 
 	return (
-		<li className="block-editor-block-types-list__list-item">
+		<li className="block-editor-block-types-list__list-item" role="option">
 			<CompositeItem
 				as={ Button }
 				{ ...composite }

diff --git a/packages/block-editor/src/components/inserter/block-types-tab.js b/packages/block-editor/src/components/inserter/block-types-tab.js
@@ -126,6 +126,7 @@ export function BlockTypesTab( {
 						items={ filteredItems }
 						onSelect={ onSelectItem }
 						onHover={ onHover }
+						label={ __( 'Child Blocks' ) }
 					/>
 				</ChildBlocks>
 			) }
@@ -139,6 +140,7 @@ export function BlockTypesTab( {
 							items={ suggestedItems }
 							onSelect={ onSelectItem }
 							onHover={ onHover }
+							label={ _x( 'Most used', 'blocks' ) }
 						/>
 					</InserterPanel>
 				) }
@@ -159,6 +161,7 @@ export function BlockTypesTab( {
 								items={ categoryItems }
 								onSelect={ onSelectItem }
 								onHover={ onHover }
+								label={ category.title }
 							/>
 						</InserterPanel>
 					);
@@ -173,6 +176,7 @@ export function BlockTypesTab( {
 						items={ uncategorizedItems }
 						onSelect={ onSelectItem }
 						onHover={ onHover }
+						label={ __( 'Uncategorized' ) }
 					/>
 				</InserterPanel>
 			) }
@@ -194,6 +198,7 @@ export function BlockTypesTab( {
 								items={ collectionItems }
 								onSelect={ onSelectItem }
 								onHover={ onHover }
+								label={ collection.title }
 							/>
 						</InserterPanel>
 					);
@@ -209,6 +214,7 @@ export function BlockTypesTab( {
 						items={ reusableItems }
 						onSelect={ onSelectItem }
 						onHover={ onHover }
+						label={ __( 'Reusable' ) }
 					/>
 					<a
 						className="block-editor-inserter__manage-reusable-blocks"

diff --git a/packages/block-editor/src/components/inserter/quick-inserter.js b/packages/block-editor/src/components/inserter/quick-inserter.js
@@ -69,6 +69,7 @@ function QuickInserterList( {
 						items={ shownBlockTypes }
 						onSelect={ onSelectBlockType }
 						onHover={ onHover }
+						label={ __( 'Blocks' ) }
 					/>
 				</InserterPanel>
 			) }