Search: Avoid double escaping (#41147)

* Search: Avoid double escaping * Use wp_unique_id
WordPress · May 19, 2022 · 410b5c0 · 410b5c0
1 parent cef2807
commit 410b5c0
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/packages/block-library/src/search/index.php b/packages/block-library/src/search/index.php
@@ -13,8 +13,6 @@
  * @return string The search block markup.
  */
 function render_block_core_search( $attributes ) {
-	static $instance_id = 0;
-
 	// Older versions of the Search block defaulted the label and buttonText
 	// attributes to `__( 'Search' )` meaning that many posts contain `<!--
 	// wp:search /-->`. Support these by defaulting an undefined label and
@@ -27,7 +25,7 @@ function render_block_core_search( $attributes ) {
 		)
 	);
 
-	$input_id            = 'wp-block-search__input-' . ++$instance_id;
+	$input_id            = wp_unique_id( 'wp-block-search__input-' );
 	$classnames          = classnames_for_block_core_search( $attributes );
 	$show_label          = ( ! empty( $attributes['showLabel'] ) ) ? true : false;
 	$use_icon_button     = ( ! empty( $attributes['buttonUseIcon'] ) ) ? true : false;
@@ -65,7 +63,7 @@ function render_block_core_search( $attributes ) {
 			'<input type="search" id="%s" class="wp-block-search__input %s" name="s" value="%s" placeholder="%s" %s required />',
 			$input_id,
 			esc_attr( $input_classes ),
-			esc_attr( get_search_query() ),
+			get_search_query(),
 			esc_attr( $attributes['placeholder'] ),
 			$inline_styles['input']
 		);