Change default value of enableCustomFields to undefined (#33931)

* Change default value of enableCustomFields to undefined * Add comment explaining true/false/undefined for enableCustomFields * Preferences: Hide 'Additional' section when custom fields are disabled and there are no meta boxes * Tweak comments Co-authored-by: Robert Anderson <robert@noisysocks.com>
WordPress · Aug 25, 2021 · 4037448 · 4037448
1 parent e7765c2
commit 4037448
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 10 deletions.
diff --git a/packages/edit-post/src/components/preferences-modal/index.js b/packages/edit-post/src/components/preferences-modal/index.js
@@ -243,14 +243,12 @@ export default function PreferencesModal() {
 								/>
 							</PageAttributesCheck>
 						</Section>
-						<Section
+						<MetaBoxesSection
 							title={ __( 'Additional' ) }
 							description={ __(
 								'Add extra areas to the editor.'
 							) }
-						>
-							<MetaBoxesSection />
-						</Section>
+						/>
 					</>
 				),
 			},

diff --git a/packages/edit-post/src/components/preferences-modal/test/__snapshots__/index.js.snap b/packages/edit-post/src/components/preferences-modal/test/__snapshots__/index.js.snap
@@ -179,12 +179,10 @@ exports[`PreferencesModal should match snapshot when the modal is active small v
             />
           </PageAttributesCheck>
         </Section>
-        <Section
+        <WithSelect(MetaBoxesSection)
           description="Add extra areas to the editor."
           title="Additional"
-        >
-          <WithSelect(MetaBoxesSection) />
-        </Section>
+        />
       </NavigationItem>
     </NavigationMenu>
   </Navigation>

diff --git a/packages/editor/src/store/defaults.js b/packages/editor/src/store/defaults.js
@@ -14,7 +14,12 @@ export const PREFERENCES_DEFAULTS = {
  *  allowedBlockTypes  boolean|Array Allowed block types
  *  richEditingEnabled boolean       Whether rich editing is enabled or not
  *  codeEditingEnabled boolean       Whether code editing is enabled or not
- *  enableCustomFields boolean       Whether the WordPress custom fields are enabled or not
+ *  enableCustomFields boolean       Whether the WordPress custom fields are enabled or not.
+ *                                     true  = the user has opted to show the Custom Fields panel at the bottom of the editor.
+ *                                     false = the user has opted to hide the Custom Fields panel at the bottom of the editor.
+ *                                     undefined = the current environment does not support Custom Fields,
+ *                                                 so the option toggle in Preferences -> Panels to
+ *                                                 enable the Custom Fields panel is not displayed.
  *  autosaveInterval   number        Autosave Interval
  *  availableTemplates array?        The available post templates
  *  disablePostFormats boolean       Whether or not the post formats are disabled
@@ -27,6 +32,6 @@ export const EDITOR_SETTINGS_DEFAULTS = {
 
 	richEditingEnabled: true,
 	codeEditingEnabled: true,
-	enableCustomFields: false,
+	enableCustomFields: undefined,
 	supportsLayout: true,
 };