Testing: Add ESLint restricted syntax for truthy length rendering (#1…

…4579)
WordPress · Mar 26, 2019 · 1f0fea9 · 1f0fea9
1 parent 8243a1c
commit 1f0fea9
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -92,6 +92,10 @@ module.exports = {
 				selector: 'CallExpression[callee.name="withDispatch"] > :function > BlockStatement > :not(VariableDeclaration,ReturnStatement)',
 				message: 'withDispatch must return an object with consistent keys. Avoid performing logic in `mapDispatchToProps`.',
 			},
+			{
+				selector: 'LogicalExpression[operator="&&"][left.property.name="length"][right.type="JSXElement"]',
+				message: 'Avoid truthy checks on length property rendering, as zero length is rendered verbatim.',
+			},
 		],
 		'react/forbid-elements': [ 'error', {
 			forbid: [