Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the incomplete data basics repo to reflect the GB handbook how-to guide #235

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

adamziel
Copy link
Contributor

@adamziel adamziel commented Jan 3, 2023

Follow-up on #227 to figure out the linting

cc @dgwyer

@adamziel adamziel changed the title updated the incomplete data basics repo to reflect the GB handbook how-to guide Updated the incomplete data basics repo to reflect the GB handbook how-to guide Jan 23, 2023
@adamziel
Copy link
Contributor Author

adamziel commented Feb 6, 2023

@ryanwelcher the checks are failing, seems like an npm install issue that's also present in trunk. Would you say this one is good to go?

@ryanwelcher
Copy link
Contributor

@ryanwelcher the checks are failing, seems like an npm install issue that's also present in trunk. Would you say this one is good to go?

Yes! I need to take a look at the failing checks but I think we're good here.

@ryanwelcher ryanwelcher merged commit 0731e08 into trunk Feb 8, 2023
@ryanwelcher ryanwelcher deleted the update-data-basics-repo branch February 8, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants