Adding a pull request action to lint files. #219
Conversation
| "eslint-plugin-prettier": "^4.0.0", | ||
| "prettier": "npm:wp-prettier@2.2.1-beta-1" |
There was a problem hiding this comment.
It's super annoying we need to add them explicitly 😞
I had to do the same trick in my personal projects.
There was a problem hiding this comment.
Yes, maybe this is just part of the best practice until we can use the standard prettier 😞
There was a problem hiding this comment.
maybe we should also allow * for prettier when configuring it as a peer dependency
There was a problem hiding this comment.
Like this - "prettier": "npm:wp-prettier@*"?
There was a problem hiding this comment.
Not here, in Gutenberg if that’s possible.
| @@ -0,0 +1,28 @@ | |||
| name: Static Linting | |||
|
|
|||
| on: [pull_request] | |||
There was a problem hiding this comment.
Should it also trigger when merged to the main branch?
There was a problem hiding this comment.
That's not a bad idea, I'll add it before merging. Thanks!
Part of #172, this PR introduces a pull request action to lint all files.