Code Quality: Update codes to pass php lint #201
Conversation
composer.json
Outdated
| "squizlabs/php_codesniffer": "^3.6", | ||
| "wp-coding-standards/wpcs": "^2.3" | ||
| }, | ||
| "scripts": { | ||
| "lint": "./vendor/bin/phpcs --standard=phpcs.xml" | ||
| "lint": "phpcs --standard=phpcs.xml" |
There was a problem hiding this comment.
Probably a Windows-specific problem, the following error occurred:
'.' is not recognized as an internal or external command,
operable program or batch file.
Script ./vendor/bin/phpcs --standard=phpcs.xml handling the lint event returned with error code 1
I changed the way to specify the path according to gutenberg repository.
There was a problem hiding this comment.
This command doesn't work for me anymore:
[InvalidArgumentException]
Script "phpcs" is not defined in this package
Let's revert this for now and come back to it in a secondary PR where we can come up with a good cross-platform approach.
09-code-data-basics-esnext/index.php
Outdated
| plugins_url( 'style.css', __FILE__ ) | ||
| plugins_url( 'style.css', __FILE__ ), | ||
| null, | ||
| get_bloginfo( 'version' ), |
There was a problem hiding this comment.
Can we reuse the $asset_file['version'] here? My concern is that this will be cached until the version of WP changes.
composer.json
Outdated
| "squizlabs/php_codesniffer": "^3.6", | ||
| "wp-coding-standards/wpcs": "^2.3" | ||
| }, | ||
| "scripts": { | ||
| "lint": "./vendor/bin/phpcs --standard=phpcs.xml" | ||
| "lint": "phpcs --standard=phpcs.xml" |
There was a problem hiding this comment.
This command doesn't work for me anymore:
[InvalidArgumentException]
Script "phpcs" is not defined in this package
Let's revert this for now and come back to it in a secondary PR where we can come up with a good cross-platform approach.
plugin-sidebar/plugin-sidebar.php
Outdated
| plugins_url( 'plugin-sidebar.css', __FILE__ ) | ||
| plugins_url( 'plugin-sidebar.css', __FILE__ ), | ||
| null, | ||
| get_bloginfo( 'version' ), |
There was a problem hiding this comment.
Same concern about the asset version being tied to the WP version.
|
Thank you for reviewing the code ! |
I have noticed many errors in the php lint.
This PR updates codes to pass correctly based on what phpcs pointed out.
Mainly, I have addressed the following:
add_actionto after function to eliminate missing doc error.@packagetag$in_footer) ofwp_register_script$ver) ofwp_register_stylenode_modules,block.asset.php)require_onceinstead ofincludeAs this is my first PR, please do not hesitate to point out any problems.