Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop generating package-lock.json files for the blocks. #198

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Stop generating package-lock.json files for the blocks. #198

merged 1 commit into from
Mar 22, 2022

Conversation

ryanwelcher
Copy link
Contributor

@ryanwelcher ryanwelcher commented Mar 21, 2022 •
edited
Loading

Mentioned in #193 (review), this PR removes any existing package-lock.json files and adds an .npmrc to each block to stop them from being generated.

@ryanwelcher ryanwelcher requested a review from gziolo March 21, 2022 18:53
gziolo
gziolo approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing it 👍🏻

@ryanwelcher ryanwelcher merged commit 8185452 into trunk Mar 22, 2022
@ryanwelcher ryanwelcher deleted the fix/remove-package-lock-files branch March 22, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanwelcher @gziolo