Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace custom docker setup with @wordpress/env. #170

Merged
merged 4 commits into from
Oct 22, 2021
Merged

Replace custom docker setup with @wordpress/env. #170

merged 4 commits into from
Oct 22, 2021

Conversation

ryanwelcher
Copy link
Contributor

This PR adds the @wordpress/env package to provide an easier and more integrated process to setting up a local dev environment

Closes #147, closes #133, closes #98, closes #6

@ryanwelcher ryanwelcher requested review from gziolo and mkaz October 22, 2021 18:04
mkaz
mkaz approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements, working with wp-env is much easier than straight docker commands.

Documentation looks right and tested it all out with no problems. 👍

@ryanwelcher ryanwelcher merged commit e0a2b27 into trunk Oct 22, 2021
@ryanwelcher ryanwelcher deleted the feature/add-wp-env branch October 22, 2021 18:28
@ryanwelcher ryanwelcher mentioned this pull request Oct 22, 2021
Closed
@gziolo
Copy link
Member

gziolo commented Oct 24, 2021

Great one 👍 It’s great to see it more aligned with Gutenberg promoting existing tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaz mkaz mkaz approved these changes

@gziolo gziolo Awaiting requested review from gziolo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ryanwelcher @gziolo @mkaz