Update Inner Blocks (ESNext) to use latest API #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
approved these changes
Oct 20, 2021
gziolo
reviewed
Oct 20, 2021
| const { name, ...settings } = json; | ||
|
|
||
| registerBlockType( name, { | ||
| ...settings, |
There was a problem hiding this comment.
One note. Technically speaking, you don't need to spread settings here. They are exposed from the server when registered with register_block_type.
There was a problem hiding this comment.
Thanks for confirming that! It was a question that came up in a couple of live streams.
There was a problem hiding this comment.
That means that whatever the client provides overrides what the server provides (if registered also on the server).
If you register blocks only with JavaScript then you surely need to spread settings from block.json here.
There was a problem hiding this comment.
Example for core blocks:
It's only settings specific to the client (UI).
This was referenced Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the effort in #152