Code style: Use wp-scripts format-js to change file formatting #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should land #108 first and remove all unnecessary changes from this PR afterward with rebase. |
649e38d to
cbd64c3
Compare
mkaz
approved these changes
Feb 26, 2020
|
Thanks @mkaz 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates WordPress packages to the latest version. The new version of
@wordpress/scriptsincludes breaking changes introduced with Prettier and opinionated code formatting.A few things that this PR includes:
format:jsscript integrated to make it easier for developers to keep one code stylelint-jsscript name was renamed tolint:jsto align withformat:jslint:pkg-jsonfrompretestin thetestscript in the rootpackage.json– I admit that it could be moved to its own PR but given the small number of reviewers in this repo, I wanted to batch it.