This repository has been archived by the owner on Jan 26, 2023. It is now read-only.
Add Full Width icon #191
Merged
Add Full Width icon #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an extra image alignment control icon, full width. The previously named full width is renamed "wide". Best done now, rather than later, when only the Gutenberg editor uses it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to add a new image layout control icon, "Full Width". In doing so, this PR also renames the recently added full width to simply "wide". See also discussion around the Gutenberg editor in WordPress/gutenberg#546, screenshot of context:
Those icons are gridicons. Here's the Dashicon version, pixels:
Context:
In working on this, my fat fingers accidentally pushed some files to master early. Sorry about that. Those are reverted in #190, which would be good to merge first.