This repository has been archived by the owner on Jul 28, 2023. It is now read-only.
Rename sufix character and island directive #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
I've tested it, and it seems to be working fine 👌 Thanks for taking care of it!
Just a minor detail: should we change the comments in the directives definition (link)?
Oh, true. I'll do that, thanks 🙂 |
This was referenced Jun 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I've renamed the directive syntax from
data-wp-on.clicktodata-wp-on--click.I've renamed the
data-wp-islanddirective todata-wp-interactive.data-wp-islandtodata-wp-interactive#238Why
How
I just renamed everything, including the regular expression.
I also added an explanation of the expression and made sure that it remains valid HTML by disallowing anything other than alphanumeric characters and hyphens. I purposely disallowed underscores to prevent confusion with hyphens.
I also renamed the prefix constant to hardcode
data-and ensure that it always generates valid HTML.I just renamed
data-wp-islandtodata-wp-interactive.