This repository has been archived by the owner on Jul 28, 2023. It is now read-only.
Fix WP_HTML_Tag_Processor imports
#162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ae13663 to
b095ffa
Compare
SantosGuillamot
suggested changes
Feb 27, 2023
There was a problem hiding this comment.
It looks great to me, Bernie 🙂
I guess this requirement doesn't make sense anymore. Should we remove it or require src/directives/wp-html.php instead?
Ah, nice find! I missed that one, and that file isn't covered by unit tests 😬 I've replaced it with |
SantosGuillamot
approved these changes
Feb 27, 2023
|
LGTM! 🙂 |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During preparation for the WP 6.2 release, the HTML Tag Processor files inside the Gutenberg plugin were moved from
lib/experimental/html/tolib/compat/wordpress-6.2/html-api/.This PR updates the import locations accordingly, and sort of "centralizes" them, so we only reference the external dependency in one file (and can potentially later to point to e.g.
lib/compat/wordpress-6.3/html-api/class-gutenberg-html-tag-processor-6-3.php, which has some features added after the WP 6.2 Feature Freeze, if needed).See #161 for more context.