EnqueuedResourcesSniff: Trigger on enqueued resources in heredoc and nowdoc syntax. #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nowdoc syntax. Includes unit tests. Also: * Adds unit tests for `T_DOUBLE_QUOTED_STRING` which were missing * Fixes bug in regexes which did not allow for quotes around the `stylesheet` phrase to be escaped. * Removed the blanket test exclusion for PHP 5.2 in favour of selective test exclusion.
westonruter
reviewed
Mar 21, 2017
| @@ -45,7 +47,7 @@ public function process( PHP_CodeSniffer_File $phpcsFile, $stackPtr ) { | |||
| $tokens = $phpcsFile->getTokens(); | |||
| $token = $tokens[ $stackPtr ]; | |||
|
|
|||
| if ( preg_match( '#rel=[\'"]?stylesheet[\'"]?#', $token['content'] ) > 0 ) { | |||
| if ( preg_match( '#rel=\\\\?[\'"]?stylesheet\\\\?[\'"]?#', $token['content'] ) > 0 ) { | |||
westonruter
approved these changes
Mar 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes unit tests.
Also:
T_DOUBLE_QUOTED_STRINGwhich were missingstylesheetphrase to be escaped.Related to #764