AbstractFunctionRestrictions: prevent some typical misidentifications of function calls #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed with function calls Includes unit test. Fixes 898
…onfused with function calls Includes unit test. Fixes 956
ce5a6d5 to
875bb2a
Compare
GaryJones
approved these changes
Mar 1, 2018
JDGrimes
approved these changes
Mar 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent class declarations being confused with function calls
Includes unit test.
Fixes #898
N.B.: I do still intend to pull a much more comprehensive class to correctly analyze
T_STRINGtokens, but that's still a work in progress. In the mean time, this is a simple fix to make.[Edit]: I've added a second commit along the same lines for preventing use statement aliases being confused with function call names.
Fixes #956